Skip to content

chore: drop deprecated RPCs masternode current, masternode winner and getpoolinfo#6567

Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom
kwvg:drop_depr
Feb 16, 2025
Merged

chore: drop deprecated RPCs masternode current, masternode winner and getpoolinfo#6567
PastaPastaPasta merged 2 commits intodashpay:developfrom
kwvg:drop_depr

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Feb 10, 2025 •
edited
Loading

Additional Information

  • masternode current, masternode winner were deprecated in dash#4060, which was included in Dash Core v0.17
  • getpoolinfo was deprecated in dash#3140, which was included in Dash Core v0.15.

Breaking Changes

Deprecated RPCs will no longer be available.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 23 milestone Feb 10, 2025
knst
knst reviewed Feb 10, 2025
View reviewed changes
knst
knst previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 97c524d

@kwvg kwvg requested a review from UdjinM6 February 14, 2025 10:28
@UdjinM6
Copy link

UdjinM6 commented Feb 14, 2025

Would prefer this PR to be split in two - one for rpc changes and one for the removal of support for old evodb formats. The latter should also have its own release notes probably. Also, pls see 9360fcf.

@kwvg kwvg changed the title chore: drop deprecated RPCs masternode current, masternode winner and getpoolinfo, drop legacy CDeterministicMNState formats chore: drop deprecated RPCs masternode current, masternode winner and getpoolinfo Feb 15, 2025
@kwvg kwvg marked this pull request as ready for review February 15, 2025 08:54
@kwvg kwvg requested review from PastaPastaPasta and knst February 15, 2025 08:54
@kwvg kwvg added the RPC Some notable changes to RPC params/behaviour/descriptions label Feb 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2025

Walkthrough

This update removes several deprecated RPC commands from the codebase. The changes eliminate the masternode current and masternode winner RPCs, as well as the getpoolinfo RPC, which was previously marked for deprecation. In terms of implementation, the respective functions in the masternode and coinjoin modules have been removed, including their command registration entries. The release notes documentation has been updated accordingly to reflect the removal of these RPCs. The underlying logic for masternode payment determination remains intact, while the deprecated commands have been fully removed from the public RPC interface.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 793dde0 and 7c81d53.

📒 Files selected for processing (3)
  • doc/release-notes-6567.md (1 hunks)
  • src/rpc/coinjoin.cpp (0 hunks)
  • src/rpc/masternode.cpp (0 hunks)
💤 Files with no reviewable changes (2)
  • src/rpc/coinjoin.cpp
  • src/rpc/masternode.cpp
✅ Files skipped from review due to trivial changes (1)
  • doc/release-notes-6567.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

UdjinM6
UdjinM6 approved these changes Feb 15, 2025
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7c81d53

knst
knst approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7c81d53

@PastaPastaPasta PastaPastaPasta merged commit 745b4e0 into dashpay:develop Feb 16, 2025
27 of 31 checks passed
thephez added a commit to thephez/dash-user-docs that referenced this pull request Nov 6, 2025
@thephez
docs(rpc): mark masternode current and winner as removed
963470d 
Related to dashpay/dash#6567
thephez added a commit to dashpay/docs that referenced this pull request Nov 10, 2025
@thephez
docs: v23.0 rpc updates (#525)
921d188 
* docs(rpc): update ProTx parameter names for Dash Core 23.0

Update all protx RPC commands to reflect renamed parameters in Dash Core 23.0.0:
- ipAndPort → coreP2PAddrs (accepts string or array)
- platformP2PPort → platformP2PAddrs (accepts string/array)
- platformHTTPPort → platformHTTPSAddrs (accepts string/array)

Updated commands include protx register, protx register_evo, protx register_fund,
protx register_fund_evo, protx register_prepare, protx register_prepare_evo,
protx update_service, and protx update_service_evo variants.

* docs(rpc): add submit param for protx commands

* docs(rpc): deprecate service field and add addresses for network info

* docs: update masternode setup with new protx format

* docs(rpc): update protx example responses

* docs(rpc): add submit field to legacy protxs

* docs(rpc): bls and quorum info updates

* docs(rpc): update quick ref and add include_immature_coinbase

Related to dashpay/dash#6601

* docs(rpc): mark masternode current and winner as removed

Related to dashpay/dash#6567

* docs(rpc): getblockfrompeer update

* docs(rpc): getblockstats update

* docs(rpc): update wallet and raw tx

decodepsbt getislocks getaddressinfo sendmany sendtoaddress scantxoutset gettransaction listtransactions listunspent

* docs(rpc): decodescript listdescriptors gettxout getcoinjoininfo updates

* docs: add prompt for using new rpcs script output to update rpc docs

* docs(rpc): decoderawtx getrawtx getblock updates

* docs(rpc): fundrawtx send walletcreatefundedpsbt updates

* chore: exclude scripts dir in conf file

* docs(rpc): add coinjoin newkeypool simulaterawtx gettxspendingprevout

* chore: add core 23.0.0 cli help output

* docs: ipandport -> corep2paddrs fixes in mn setup

* docs: correct version added for include_immature_coinbase

* docs: update mn protx example commands

* docs: clarify include_immature_coinbase

* docs: add missing listdescriptors param and update response description

* docs(rpc): update version highlighting in quick ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

23

Development

Successfully merging this pull request may close these issues.

4 participants

@kwvg @UdjinM6 @knst @PastaPastaPasta